device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc - Issue 2907913002: Fix ManufacturerData and ServiceData DBus data type to match with bluez.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc

Issue 2907913002: Fix ManufacturerData and ServiceData DBus data type to match with bluez. (Closed)

Patch Set: Fix ManufacturerData and ServiceData DBus data type to match with bluez. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc

diff --git a/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc b/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc

index 3c7addf719a9a2030df75396cdb5a80e1cd9e66d..3175bd3671359e5650df0c5fe4d3013fc06c3428 100644

--- a/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc

+++ b/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc

@@ -234,7 +234,7 @@ TEST_F(BluetoothAdvertisementBlueZTest, RegisterTooManyFailed) {

// The next advertisement should fail to register.

current_advertisement = CreateAdvertisement();

- ExpectError(BluetoothAdvertisement::ERROR_ADVERTISEMENT_ALREADY_EXISTS);

+ ExpectError(BluetoothAdvertisement::ERROR_ADVERTISEMENT_FAILED);

rkc 2017/06/01 18:10:50 What's the difference between ALREADY_EXISTS and F

EXPECT_FALSE(current_advertisement);

}