Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3423)

Unified Diff: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Issue 2907873002: views: impose minimum width on non-Harmony snappables (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
index f17a7fc6306f26a976ce2912b11639c23d387a8c..04254b32d65de7da82a00d5d49e2d02a6ede1ff8 100644
--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
@@ -157,7 +157,6 @@ class PermissionsBubbleDialogDelegateView
const gfx::FontList& GetTitleFontList() const override;
base::string16 GetWindowTitle() const override;
void OnWidgetDestroying(views::Widget* widget) override;
- gfx::Size GetPreferredSize() const override;
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
bool Cancel() override;
bool Accept() override;
@@ -304,12 +303,6 @@ void PermissionsBubbleDialogDelegateView::OnWidgetDestroying(
}
}
-gfx::Size PermissionsBubbleDialogDelegateView::GetPreferredSize() const {
- // TODO(estade): bubbles should default to this width.
- const int kWidth = 320 - GetInsets().width();
- return gfx::Size(kWidth, GetHeightForWidth(kWidth));
-}
-
void PermissionsBubbleDialogDelegateView::GetAccessibleNodeData(
ui::AXNodeData* node_data) {
views::BubbleDialogDelegateView::GetAccessibleNodeData(node_data);

Powered by Google App Engine
This is Rietveld 408576698