views: impose minimum width on non-Harmony snappables

chrome/browser/ui/views/harmony/chrome_layout_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
 #define CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 58 matching lines @@
   virtual bool ShouldShowWindowIcon() const;
 
   // DEPRECATED.  Returns whether Harmony mode is enabled.
   //
   // Instead of using this, create a generic solution that works for all UI
   // types, e.g. by adding a new LayoutDistance value that means what you need.
   //
   // TODO(pkasting): Fix callers and remove this.
   virtual bool IsHarmonyMode() const;
 
+  // Returns the snapped width for snapped dialogs. This is used to enforce a
+  // minimum width for snap-able dialogs even in non-Harmony modes.
+  int GetSnappedDialogWidth(int min_width) const override;

[Peter Kasting, 2017/05/26 23:59:10]

It seems like rather than overriding here we should put this implementation in
the base class.

We expect users to be using either the "chrome" or "harmony" layout provider as
their concrete provider, so the only cases affected would be unittests.  Did you
originally place this here and not there to avoid affecting tests?

[Elly Fong-Jones, 2017/05/30 14:55:36]

I put this here because I think we are trying to keep Harmony-specific (or
Chrome-specific) stuff out of //ui/views, but I was on the fence about whether
this is Chrome-specific or not. If it seems like it's not, then I can gladly
move this to the base class :)

[Peter Kasting, 2017/05/30 16:17:54]

I would probably move it under the justification that it's behavior we want to
affect other code that lives in ui/views/.

+
  private:
   DISALLOW_COPY_AND_ASSIGN(ChromeLayoutProvider);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_HARMONY_CHROME_LAYOUT_PROVIDER_H_