views: impose minimum width on non-Harmony snappables

chrome/browser/ui/views/harmony/chrome_layout_provider.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/ui/views/harmony/chrome_typography.h"
 #include "chrome/browser/ui/views/harmony/harmony_layout_provider.h"
@@ skipping 59 matching lines @@
   return true;
 }
 
 bool ChromeLayoutProvider::ShouldShowWindowIcon() const {
   return true;
 }
 
 bool ChromeLayoutProvider::IsHarmonyMode() const {
   return false;
 }
+
+int ChromeLayoutProvider::GetSnappedDialogWidth(int min_width) const {
+  // This is an arbitrary value, but it's a good arbitrary value. Some dialogs
+  // have very small widths for their contents views, which causes ugly
+  // title-wrapping where a two-word title is split across multiple lines or
+  // similar. To prevent that, forbid any snappable dialog from being narrower
+  // than this value.

[Peter Kasting, 2017/05/26 23:59:10]

Nit: Dunno whether you want to say "we could try to factor in the desired title
width as well here, but it's not worth the complication."

[Elly Fong-Jones, 2017/05/30 14:55:36]

Done.

+  return min_width < 320 ? 320 : min_width;

[Peter Kasting, 2017/05/26 23:59:10]

Nit: Simpler:

  return std::max(min_width, 320);

[Elly Fong-Jones, 2017/05/30 14:55:36]

Done.

+}