js_checker.py: Replace custom GetElementByIdCheck with ESLint no-restricted-properties.

tools/web_dev_style/js_checker.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for Chromium JS resources.
 
 See chrome/browser/PRESUBMIT.py
 """
 
 import regex_check
@@ skipping 34 matching lines @@
   def EndJsDocCommentCheck(self, i, line):
     msg = 'End JSDoc comments with */ instead of **/'
     def _check(regex):
       return self.RegexCheck(i, line, regex, msg)
     return _check(r'^\s*(\*\*/)\s*$') or _check(r'/\*\* @[a-zA-Z]+.* (\*\*/)')
 
   def ExtraDotInGenericCheck(self, i, line):
     return self.RegexCheck(i, line, r"((?:Array|Object|Promise)\.<)",
         "Don't use a dot after generics (Object.<T> should be Object<T>).")
 
-  def GetElementByIdCheck(self, i, line):
-    """Checks for use of 'document.getElementById' instead of '$'."""
-    return self.RegexCheck(i, line, r"(document\.getElementById)\('",
-        "Use $('id') or getSVGElement('id') from chrome://resources/js/util.js "
-        "instead of document.getElementById('id')")
-
   def InheritDocCheck(self, i, line):
     """Checks for use of '@inheritDoc' instead of '@override'."""
     return self.RegexCheck(i, line, r"\* (@inheritDoc)",
         "@inheritDoc is deprecated, use @override instead")
 
   def PolymerLocalIdCheck(self, i, line):
     """Checks for use of element.$.localId."""
     return self.RegexCheck(i, line, r"(?<!this)(\.\$)[\[\.]",
         "Please only use this.$.localId, not element.$.localId")
 
@@ skipping 63 matching lines @@
       results += self.RunEsLintChecks(affected_js_files)
 
     for f in affected_js_files:
       error_lines = []
 
       for i, line in enumerate(f.NewContents(), start=1):
         error_lines += filter(None, [
             self.ChromeSendCheck(i, line),
             self.CommentIfAndIncludeCheck(i, line),
             self.ConstCheck(i, line),
-            self.GetElementByIdCheck(i, line),
             self.EndJsDocCommentCheck(i, line),
             self.ExtraDotInGenericCheck(i, line),
             self.InheritDocCheck(i, line),
             self.PolymerLocalIdCheck(i, line),
             self.WrapperTypeCheck(i, line),
             self.VarNameCheck(i, line),
         ])
 
       if error_lines:
         error_lines = [
             'Found JavaScript style violations in %s:' %
             f.LocalPath()] + error_lines
         results.append(self.output_api.PresubmitError('\n'.join(error_lines)))
 
     if results:
       results.append(self.output_api.PresubmitNotifyResult(
           'See the JavaScript style guide at '
           'https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md#JavaScript'))
 
     return results