Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2607)

Unified Diff: net/quic/core/crypto/crypto_server_test.cc

Issue 2907743003: Change CryptoHandshakeMessage::GetTaglist to tag a QuicTagVector* (Closed)
Patch Set: fix QuicConfig Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/crypto/crypto_server_test.cc
diff --git a/net/quic/core/crypto/crypto_server_test.cc b/net/quic/core/crypto/crypto_server_test.cc
index 13a040e76b549d20694835275d7d3e00b2003dbf..1ca1e1edb0f383182851b3f2ef898732fa496502 100644
--- a/net/quic/core/crypto/crypto_server_test.cc
+++ b/net/quic/core/crypto/crypto_server_test.cc
@@ -216,11 +216,10 @@ class CryptoServerTest : public QuicTestWithParam<TestParams> {
};
void CheckServerHello(const CryptoHandshakeMessage& server_hello) {
- const QuicTag* versions;
- size_t num_versions;
- server_hello.GetTaglist(kVER, &versions, &num_versions);
- ASSERT_EQ(supported_versions_.size(), num_versions);
- for (size_t i = 0; i < num_versions; ++i) {
+ QuicTagVector versions;
+ server_hello.GetTaglist(kVER, &versions);
+ ASSERT_EQ(supported_versions_.size(), versions.size());
+ for (size_t i = 0; i < versions.size(); ++i) {
EXPECT_EQ(QuicVersionToQuicTag(supported_versions_[i]), versions[i]);
}
@@ -340,15 +339,13 @@ class CryptoServerTest : public QuicTestWithParam<TestParams> {
void CheckRejectReasons(
const HandshakeFailureReason* expected_handshake_failures,
size_t expected_count) {
- const uint32_t* reject_reasons;
- size_t num_reject_reasons;
+ QuicTagVector reject_reasons;
static_assert(sizeof(QuicTag) == sizeof(uint32_t), "header out of sync");
- QuicErrorCode error_code =
- out_.GetTaglist(kRREJ, &reject_reasons, &num_reject_reasons);
+ QuicErrorCode error_code = out_.GetTaglist(kRREJ, &reject_reasons);
ASSERT_EQ(QUIC_NO_ERROR, error_code);
- EXPECT_EQ(expected_count, num_reject_reasons);
- for (size_t i = 0; i < num_reject_reasons; ++i) {
+ EXPECT_EQ(expected_count, reject_reasons.size());
+ for (size_t i = 0; i < reject_reasons.size(); ++i) {
EXPECT_EQ(expected_handshake_failures[i], reject_reasons[i]);
}
}

Powered by Google App Engine
This is Rietveld 408576698