Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: net/quic/core/crypto/crypto_handshake_message.h

Issue 2907743003: Change CryptoHandshakeMessage::GetTaglist to tag a QuicTagVector* (Closed)
Patch Set: fix QuicConfig Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/crypto/crypto_handshake_message.h
diff --git a/net/quic/core/crypto/crypto_handshake_message.h b/net/quic/core/crypto/crypto_handshake_message.h
index 6275faad4c885ee24b62dda60ebca9f43326d20c..f646ce59fc143281747e9c1e861e5b139ec4efe5 100644
--- a/net/quic/core/crypto/crypto_handshake_message.h
+++ b/net/quic/core/crypto/crypto_handshake_message.h
@@ -73,13 +73,8 @@ class QUIC_EXPORT_PRIVATE CryptoHandshakeMessage {
// GetTaglist finds an element with the given tag containing zero or more
// tags. If such a tag doesn't exist, it returns an error code. Otherwise it
- // sets |out_tags| and |out_len| to point to the array of tags and returns
- // QUIC_NO_ERROR. The array points into the CryptoHandshakeMessage and is
- // valid only for as long as the CryptoHandshakeMessage exists and is not
- // modified.
- QuicErrorCode GetTaglist(QuicTag tag,
- const QuicTag** out_tags,
- size_t* out_len) const;
+ // populates |out_tags| with the tags and returns QUIC_NO_ERROR.
+ QuicErrorCode GetTaglist(QuicTag tag, QuicTagVector* out_tags) const;
bool GetStringPiece(QuicTag tag, QuicStringPiece* out) const;
bool HasStringPiece(QuicTag tag) const;
« no previous file with comments | « no previous file | net/quic/core/crypto/crypto_handshake_message.cc » ('j') | net/quic/core/crypto/crypto_handshake_message.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698