Change CryptoHandshakeMessage::GetTaglist to tag a QuicTagVector*

net/quic/core/crypto/crypto_utils.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/crypto/crypto_utils.h"
 
 #include <memory>
 
 #include "crypto/hkdf.h"
 #include "net/quic/core/crypto/crypto_handshake.h"
@@ skipping 170 matching lines @@
     const CryptoHandshakeMessage& server_hello,
     const QuicVersionVector& negotiated_versions,
     string* error_details) {
   DCHECK(error_details != nullptr);
 
   if (server_hello.tag() != kSHLO) {
     *error_details = "Bad tag";
     return QUIC_INVALID_CRYPTO_MESSAGE_TYPE;
   }
 
-  const QuicTag* supported_version_tags;
-  size_t num_supported_versions;
-
-  if (server_hello.GetTaglist(kVER, &supported_version_tags,
-                              &num_supported_versions) != QUIC_NO_ERROR) {
+  QuicTagVector supported_version_tags;
+  if (server_hello.GetTaglist(kVER, &supported_version_tags) != QUIC_NO_ERROR) {
     *error_details = "server hello missing version list";
     return QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER;
   }
   if (!negotiated_versions.empty()) {
-    bool mismatch = num_supported_versions != negotiated_versions.size();
-    for (size_t i = 0; i < num_supported_versions && !mismatch; ++i) {
+    bool mismatch = supported_version_tags.size() != negotiated_versions.size();
+    for (size_t i = 0; i < supported_version_tags.size() && !mismatch; ++i) {
       mismatch = QuicTagToQuicVersion(supported_version_tags[i]) !=
                  negotiated_versions[i];
     }
     // The server sent a list of supported versions, and the connection
     // reports that there was a version negotiation during the handshake.
     // Ensure that these two lists are identical.
     if (mismatch) {
       *error_details = "Downgrade attack detected";
       return QUIC_VERSION_NEGOTIATION_MISMATCH;
     }
@@ skipping 83 matching lines @@
                                        string* output,
                                        Perspective perspective) {
   const QuicData& serialized = message.GetSerialized(perspective);
   uint8_t digest[SHA256_DIGEST_LENGTH];
   SHA256(reinterpret_cast<const uint8_t*>(serialized.data()),
          serialized.length(), digest);
   output->assign(reinterpret_cast<const char*>(digest), sizeof(digest));
 }
 
 }  // namespace net