Change CryptoHandshakeMessage::GetTaglist to tag a QuicTagVector*

net/quic/core/crypto/quic_crypto_client_config.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/crypto/quic_crypto_client_config.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "base/metrics/histogram_macros.h"
@@ skipping 509 matching lines @@
 
   QuicStringPiece scid;
   if (!scfg->GetStringPiece(kSCID, &scid)) {
     *error_details = "SCFG missing SCID";
     return QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER;
   }
   out->SetStringPiece(kSCID, scid);
 
   out->SetStringPiece(kCertificateSCTTag, "");
 
-  const QuicTag* their_aeads;
-  const QuicTag* their_key_exchanges;
-  size_t num_their_aeads, num_their_key_exchanges;
-  if (scfg->GetTaglist(kAEAD, &their_aeads, &num_their_aeads) !=
-          QUIC_NO_ERROR ||
-      scfg->GetTaglist(kKEXS, &their_key_exchanges, &num_their_key_exchanges) !=
-          QUIC_NO_ERROR) {
+  QuicTagVector their_aeads;
+  QuicTagVector their_key_exchanges;
+  if (scfg->GetTaglist(kAEAD, &their_aeads) != QUIC_NO_ERROR ||
+      scfg->GetTaglist(kKEXS, &their_key_exchanges) != QUIC_NO_ERROR) {
     *error_details = "Missing AEAD or KEXS";
     return QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER;
   }
 
   // AEAD: the work loads on the client and server are symmetric. Since the
   // client is more likely to be CPU-constrained, break the tie by favoring
   // the client's preference.
   // Key exchange: the client does more work than the server, so favor the
   // client's preference.
   size_t key_exchange_index;
-  if (!FindMutualQuicTag(aead, their_aeads, num_their_aeads, &out_params->aead,
-                         nullptr) ||
-      !FindMutualQuicTag(kexs, their_key_exchanges, num_their_key_exchanges,
-                         &out_params->key_exchange, &key_exchange_index)) {
+  if (!FindMutualQuicTag(aead, their_aeads.data(), their_aeads.size(),
+                         &out_params->aead, nullptr) ||
+      !FindMutualQuicTag(kexs, their_key_exchanges.data(),
+                         their_key_exchanges.size(), &out_params->key_exchange,
+                         &key_exchange_index)) {
     *error_details = "Unsupported AEAD or KEXS";
     return QUIC_CRYPTO_NO_SUPPORT;
   }
   out->SetVector(kAEAD, QuicTagVector{out_params->aead});
   out->SetVector(kKEXS, QuicTagVector{out_params->key_exchange});
 
   if (!tb_key_params.empty() &&
       server_id.privacy_mode() == PRIVACY_MODE_DISABLED) {
-    const QuicTag* their_tbkps;
-    size_t num_their_tbkps;
-    switch (scfg->GetTaglist(kTBKP, &their_tbkps, &num_their_tbkps)) {
+    QuicTagVector their_tbkps;
+    switch (scfg->GetTaglist(kTBKP, &their_tbkps)) {
       case QUIC_CRYPTO_MESSAGE_PARAMETER_NOT_FOUND:
         break;
       case QUIC_NO_ERROR:
-        if (FindMutualQuicTag(tb_key_params, their_tbkps, num_their_tbkps,
+        if (FindMutualQuicTag(tb_key_params, their_tbkps.data(),
+                              their_tbkps.size(),
                               &out_params->token_binding_key_param, nullptr)) {
           out->SetVector(kTBKP,
                          QuicTagVector{out_params->token_binding_key_param});
         }
         break;
       default:
         *error_details = "Invalid TBKP";
         return QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER;
     }
   }
@@ skipping 417 matching lines @@
   }
 
   // Update canonical version to point at the "most recent" entry.
   canonical_server_map_[suffix_server_id] = server_id;
 
   server_state->InitializeFrom(*canonical_state);
   return true;
 }
 
 }  // namespace net