Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 290773004: First attempt at cleaning up chrome_resources.gyp. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang, oshima
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

First attempt at cleaning up chrome_resources.gyp. This first prefix action_names with 'generate' to differentiate them from the target names. This also collapses theme_resources_gen into theme_resources as there is no reason to separate them. It also removes a second declaration of grit_out_dir variable. We don't need to declare it twice in the same file. BUG=None TEST=None R=thestig@chromium.org TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -46 lines) Patch
M chrome/chrome_resources.gyp View 11 chunks +28 lines, -38 lines 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Lei, I'm trying to make more reason of this file. To make it more hackable. ...
6 years, 7 months ago (2014-05-17 04:04:36 UTC) #1
Lei Zhang
lgtm +oshima in case he has any concerns/comments
6 years, 7 months ago (2014-05-19 22:10:20 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-19 22:14:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/290773004/1
6 years, 7 months ago (2014-05-19 22:15:54 UTC) #4
oshima
lgtm
6 years, 7 months ago (2014-05-19 22:23:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 01:43:04 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 06:15:30 UTC) #7
Message was sent while issue was closed.
Change committed as 271579

Powered by Google App Engine
This is Rietveld 408576698