Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: ios/web/public/web_state/ui/crw_native_content_provider.h

Issue 2907723003: Deprecated -[CRWNativeContentProvider controllerForURL:withError:isPost:] (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/web_state/ui/crw_native_content_provider.h
diff --git a/ios/web/public/web_state/ui/crw_native_content_provider.h b/ios/web/public/web_state/ui/crw_native_content_provider.h
index da0ab24eddc4a640d35ffc51d6cac5f3f8c18c55..07595ba9bffc3c1da99d8316064015084383a534 100644
--- a/ios/web/public/web_state/ui/crw_native_content_provider.h
+++ b/ios/web/public/web_state/ui/crw_native_content_provider.h
@@ -31,6 +31,11 @@ class WebState;
// within the web content area. The native view will contain an error page
// with information appropriate for the problem described in |error|.
// |isPost| indicates whether the error was for a post request.
+//
+// DEPRECATED! Clients must use WebStateObserver::DidFinishNavigation and check
+// for NavigationContext::GetError() and NavigationContext::IsPost().
+// TODO(crbug.com/725241): Remove this method once clients are switched to use
+// DidFinishNavigaiton.
- (id<CRWNativeContent>)controllerForURL:(const GURL&)url
withError:(NSError*)error
isPost:(BOOL)isPost;
marq (ping after 24h) 2017/05/29 10:02:07 Add "__attribute__((deprecated))" or its macro equ
Eugene But (OOO till 7-30) 2017/05/30 17:49:45 This throws "error: 'controllerForURL:withError:is
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698