Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2907673002: Files are added with absolute URIs, but invalidated with file URIs. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Files are added with absolute URIs, but invalidated with file URIs. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/30b51f7403a5cf375137be1a1b7302f9ec9853bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M pkg/front_end/lib/src/incremental/file_state.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-25 20:07:37 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-25 20:28:55 UTC) #2
scheglov
3 years, 7 months ago (2017-05-25 20:42:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30b51f7403a5cf375137be1a1b7302f9ec9853bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698