Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2907663004: FrameTree::Find only searches relative to local frames. (Closed)
Patch Set: Addressed CR feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 8ded215535f47e19580aa04d8161b5e21409f647..d0b68bf155c63568ea03db5ad2d97dd5c95704a0 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -156,6 +156,7 @@
#include "v8/include/v8.h"
#include "web/TextFinder.h"
#include "web/WebRemoteFrameImpl.h"
+#include "web/WebViewImpl.h"
#include "web/tests/FrameTestHelpers.h"
#include "web/tests/sim/SimDisplayItemList.h"
#include "web/tests/sim/SimRequest.h"
@@ -4373,8 +4374,9 @@ TEST_P(ParameterizedWebFrameTest, IframeRedirect) {
FrameTestHelpers::PumpPendingRequestsForFrameToLoad(
web_view_helper.WebView()->MainFrame());
- WebFrame* iframe = web_view_helper.WebView()->FindFrameByName(
- WebString::FromUTF8("ifr"), nullptr);
+ WebFrame* iframe = static_cast<WebViewImpl*>(web_view_helper.WebView())
dcheng 2017/05/26 20:16:19 WebView() already returns a WebViewImpl, no static
Łukasz Anforowicz 2017/05/26 20:51:19 Doh - thanks for pointing this out. Done (but sti
+ ->MainFrameImpl()
+ ->FindFrameByName(WebString::FromUTF8("ifr"));
ASSERT_TRUE(iframe);
WebDataSource* iframe_data_source = iframe->DataSource();
ASSERT_TRUE(iframe_data_source);
« no previous file with comments | « third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698