Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: tools/perf/page_sets/loading_mobile.py

Issue 2907643002: Explicitly setting story names for the loading_mobile story set. (Closed)
Patch Set: Shortening lines Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from page_sets import page_cycler_story 5 from page_sets import page_cycler_story
6 from telemetry.page import cache_temperature as cache_temperature_module 6 from telemetry.page import cache_temperature as cache_temperature_module
7 from telemetry.page import shared_page_state 7 from telemetry.page import shared_page_state
8 from telemetry.page import traffic_setting as traffic_setting_module 8 from telemetry.page import traffic_setting as traffic_setting_module
9 from telemetry import story 9 from telemetry import story
10 10
11 11
12 class LoadingMobileStorySet(story.StorySet): 12 class LoadingMobileStorySet(story.StorySet):
13 13
14 """ A collection of tests to measure loading performance of mobile sites. 14 """ A collection of tests to measure loading performance of mobile sites.
15 15
16 Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXh t3ogeF9yLNFCI/edit 16 Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXh t3ogeF9yLNFCI/edit
17 """ 17 """
18 18
19 def __init__(self, cache_temperatures=None, traffic_settings=None): 19 def __init__(self, cache_temperatures=None, traffic_settings=None):
20 super(LoadingMobileStorySet, self).__init__( 20 super(LoadingMobileStorySet, self).__init__(
21 archive_data_file='data/loading_mobile.json', 21 archive_data_file='data/loading_mobile.json',
22 cloud_storage_bucket=story.PARTNER_BUCKET) 22 cloud_storage_bucket=story.PARTNER_BUCKET,
23 verify_names=True)
23 24
24 if cache_temperatures is None: 25 if cache_temperatures is None:
25 cache_temperatures = [cache_temperature_module.ANY] 26 cache_temperatures = [cache_temperature_module.ANY]
26 27
27 if traffic_settings is None: 28 if traffic_settings is None:
28 traffic_settings = [traffic_setting_module.NONE] 29 traffic_settings = [traffic_setting_module.NONE]
29 30
30 self.AddStories(['global'], [ 31 self.AddStories(['global'], [
31 'https://www.google.com/search?q=flower#q=flower+delivery', 32 ('https://www.google.com/search?q=flower#q=flower+delivery',
32 'https://www.youtube.com/watch?v=MU3YuvNRhVY', 33 'google.com'),
rnephew (Reviews Here) 2017/05/25 20:10:33 I think the indentation is off, I think it should
ashleymarie1 2017/05/25 20:19:17 I thought it would be closer to if (width == 0 and
34 ('https://www.youtube.com/watch?v=MU3YuvNRhVY', 'youtube.com'),
33 # pylint: disable=line-too-long 35 # pylint: disable=line-too-long
34 'https://www.google.co.in/search?q=%E0%A4%AB%E0%A5%82%E0%A4%B2&rct=j#q=%E0 %A4%AB%E0%A5%82%E0%A4%B2+%E0%A4%B5%E0%A4%BF%E0%A4%A4%E0%A4%B0%E0%A4%A3', 36 ('https://www.google.co.in/search?q=%E0%A4%AB%E0%A5%82%E0%A4%B2&rct=j#q=%E 0%A4%AB%E0%A5%82%E0%A4%B2+%E0%A4%B5%E0%A4%BF%E0%A4%A4%E0%A4%B0%E0%A4%A3',
35 'https://www.google.com.br/search?q=flor#q=Entrega+de+flores&start=10', 37 'google.co.in'),
38 ('https://www.google.com.br/search?q=flor#q=Entrega+de+flores&start=10',
39 'google.com.br'),
36 # Disabled because of crbug.com/653775 40 # Disabled because of crbug.com/653775
37 # pylint: disable=line-too-long 41 # pylint: disable=line-too-long
38 # 'https://googleblog.blogspot.jp/2016/02/building-safer-web-for-everyone. html', 42 # ('https://googleblog.blogspot.jp/2016/02/building-safer-web-for-everyone .html',
39 'https://www.google.co.id/#q=pengiriman+bunga', 43 # 'googleblog.blogspot.jp'),
40 'https://m.facebook.com/?soft=messages', 44 ('https://www.google.co.id/#q=pengiriman+bunga', 'google.co.id'),
45 ('https://m.facebook.com/?soft=messages', 'm.facebook.com'),
41 # Disabled because of crbug.com/656861 46 # Disabled because of crbug.com/656861
42 # pylint: disable=line-too-long 47 # pylint: disable=line-too-long
43 # 'http://g1.globo.com/politica/noticia/2016/02/maioria-do-stf-autoriza-fi sco-obter-dados-bancarios-sem-decisao-judicial.html', 48 # ('http://g1.globo.com/politica/noticia/2016/02/maioria-do-stf-autoriza-f isco-obter-dados-bancarios-sem-decisao-judicial.html',
49 # 'g1.globo.com'),
44 # pylint: disable=line-too-long 50 # pylint: disable=line-too-long
45 'https://m.baidu.com/s?word=%E9%B2%9C%E8%8A%B1%E9%80%9F%E9%80%92&oq=%E9%B2 %9C%E8%8A%B1', 51 ('https://m.baidu.com/s?word=%E9%B2%9C%E8%8A%B1%E9%80%9F%E9%80%92&oq=%E9%B 2%9C%E8%8A%B1',
52 'm.baidu.com'),
46 # pylint: disable=line-too-long 53 # pylint: disable=line-too-long
47 'http://news.yahoo.com/were-top-10-most-visited-us-national-parks-10532372 7.html', 54 ('http://news.yahoo.com/were-top-10-most-visited-us-national-parks-1053237 27.html',
48 'https://en.m.wikipedia.org/wiki/Solo_Foods', 55 'news.yahoo.com'),
56 ('https://en.m.wikipedia.org/wiki/Solo_Foods', 'en.m.wikipedia.org'),
49 # pylint: disable=line-too-long 57 # pylint: disable=line-too-long
50 'http://noticias.bol.uol.com.br/ultimas-noticias/brasil/2016/08/03/tufao-n ida-nao-deixa-vitimas-mas-prejuizos-de-us-43-milhoes.htm', 58 ('http://noticias.bol.uol.com.br/ultimas-noticias/brasil/2016/08/03/tufao- nida-nao-deixa-vitimas-mas-prejuizos-de-us-43-milhoes.htm',
59 'noticias.bol.uol.com.br'),
51 # Disabled because of crbug.com/653775 60 # Disabled because of crbug.com/653775
52 # pylint: disable=line-too-long 61 # pylint: disable=line-too-long
53 # 'http://m.detik.com/finance/read/2016/02/19/151843/3146351/1034/ekspor-t ambang-mentah-mau-dibuka-lagi-kalau-sudah-bangun-smelter-bagaimana', 62 # ('http://m.detik.com/finance/read/2016/02/19/151843/3146351/1034/ekspor- tambang-mentah-mau-dibuka-lagi-kalau-sudah-bangun-smelter-bagaimana',
54 'http://www.amazon.com/gp/aw/s/ref=is_s/189-8585431-1246432?k=shoes', 63 # 'm.detik.com'),
64 ('http://www.amazon.com/gp/aw/s/ref=is_s/189-8585431-1246432?k=shoes',
65 'amazon.com'),
55 # pylint: disable=line-too-long 66 # pylint: disable=line-too-long
56 'http://m.tribunnews.com/superskor/2016/08/03/ribuan-polisi-dikerahkan-men gawal-bonek', 67 ('http://m.tribunnews.com/superskor/2016/08/03/ribuan-polisi-dikerahkan-me ngawal-bonek',
57 'http://xw.qq.com/news/20160803025029/NEW2016080302502901', 68 'm.tribunnews.com'),
69 ('http://xw.qq.com/news/20160803025029/NEW2016080302502901', 'xw.qq.com'),
58 # pylint: disable=line-too-long 70 # pylint: disable=line-too-long
59 'http://m.kaskus.co.id/thread/57a03a3214088d91068b4567/inilah-akibat-bersi kap-overprotektif-terhadap-anak/?ref=homelanding&med=hot_thread', 71 ('http://m.kaskus.co.id/thread/57a03a3214088d91068b4567/inilah-akibat-bers ikap-overprotektif-terhadap-anak/?ref=homelanding&med=hot_thread',
60 'http://www.dailymotion.com/video/x3d1kj5_fallout-4-review_videogames', 72 'm.kaskus.co.id'),
61 'https://mobile.twitter.com/scottjehl/status/760618697727803394', 73 ('http://www.dailymotion.com/video/x3d1kj5_fallout-4-review_videogames',
62 'http://m.kapanlagi.com/lirik/artis/anji/kata_siapa/', 74 'dailymotion.com'),
75 ('https://mobile.twitter.com/scottjehl/status/760618697727803394',
76 'mobile.twitter.com'),
77 ('http://m.kapanlagi.com/lirik/artis/anji/kata_siapa/',
78 'm.kapanlagi.com'),
63 # pylint: disable=line-too-long 79 # pylint: disable=line-too-long
64 'http://olx.co.id/iklan/iphone-6s-64-rose-gold-warna-favorite-IDiSdm5.html #5310a118c3;promoted', 80 ('http://olx.co.id/iklan/iphone-6s-64-rose-gold-warna-favorite-IDiSdm5.htm l#5310a118c3;promoted',
81 'olx.co.id'),
65 # pylint: disable=line-too-long 82 # pylint: disable=line-too-long
66 'http://enquiry.indianrail.gov.in/mntes/MntesServlet?action=MainMenu&subAc tion=excep&excpType=EC', 83 ('http://enquiry.indianrail.gov.in/mntes/MntesServlet?action=MainMenu&subA ction=excep&excpType=EC',
84 'enquiry.indianrail.gov.in'),
67 ], cache_temperatures, traffic_settings) 85 ], cache_temperatures, traffic_settings)
68 86
69 self.AddStories(['pwa'], [ 87 self.AddStories(['pwa'], [
70 # pylint: disable=line-too-long 88 # pylint: disable=line-too-long
71 'https://www.flipkart.com/big-wing-casuals/p/itmemeageyfn6m9z?lid=LSTSHOEM EAGURG2PHPW18FTBN&pid=SHOEMEAGURG2PHPW', 89 ('https://www.flipkart.com/big-wing-casuals/p/itmemeageyfn6m9z?lid=LSTSHOE MEAGURG2PHPW18FTBN&pid=SHOEMEAGURG2PHPW',
72 'https://smp.suumo.jp/mansion/tokyo/sc_104/cond/?moreCond=1', 90 'flipkart.com'),
91 ('https://smp.suumo.jp/mansion/tokyo/sc_104/cond/?moreCond=1',
92 'smp.suumo.jp'),
73 # Disabled because of crbug.com/653775 93 # Disabled because of crbug.com/653775
74 # 'https://airhorner.com', 94 # 'https://airhorner.com', 'airhorner.com'),
75 'https://guitar-tuner.appspot.com', 95 ('https://guitar-tuner.appspot.com', 'guitar-tuner.appspot.com'),
76 # Disabled because of crbug.com/653775 96 # Disabled because of crbug.com/653775
77 # 'https://busrouter.sg', 97 # ('https://busrouter.sg', 'busrouter.sg'),
78 'https://andreasbovens.github.io/inbox-attack/', 98 ('https://andreasbovens.github.io/inbox-attack/',
79 'https://voice-memos.appspot.com', 99 'andreasbovens.github.io'),
100 ('https://voice-memos.appspot.com', 'voice-memos.appspot.com'),
80 # Disabled because of crbug.com/653775 101 # Disabled because of crbug.com/653775
81 # 'https://wiki-offline.jakearchibald.com/', 102 # ('https://wiki-offline.jakearchibald.com/',
82 'https://dev.opera.com/', 103 # 'wiki-offline.jakearchibald.com'),
83 'https://www.pokedex.org/', 104 ('https://dev.opera.com/', 'dev.opera.com'),
84 'https://2048-opera-pwa.surge.sh/', 105 ('https://www.pokedex.org/', 'pokedex.org'),
85 'https://jakearchibald.github.io/trained-to-thrill/', 106 ('https://2048-opera-pwa.surge.sh/', '2048-opera-pwa.surge.sh'),
86 'https://townwork.net', 107 ('https://jakearchibald.github.io/trained-to-thrill/',
87 'https://flipboard.com/topic/yoga', 108 'jakearchibald.github.io'),
109 ('https://townwork.net', 'townwork.net'),
110 ('https://flipboard.com/topic/yoga', 'flipboard.com'),
88 ], cache_temperatures, traffic_settings) 111 ], cache_temperatures, traffic_settings)
89 112
90 self.AddStories(['tough_ttfmp'], [ 113 self.AddStories(['tough_ttfmp'], [
91 'http://www.localmoxie.com', 114 ('http://www.localmoxie.com', 'localmoxie.com'),
92 'http://www.dawn.com', 115 ('http://www.dawn.com', 'dawn.com'),
93 'http://www.thairath.co.th', 116 ('http://www.thairath.co.th', 'thairath.co.th'),
94 # Disabled to avoid Nexus5X bot timeout crbug.com/702175 117 # Disabled to avoid Nexus5X bot timeout crbug.com/702175
95 # 'http://www.hashocean.com', 118 # ('http://www.hashocean.com', 'hashocean.com'),
96 # 'http://www.163.com', 119 # ('http://www.163.com', '163.com'),
97 ], cache_temperatures, traffic_settings) 120 ], cache_temperatures, traffic_settings)
98 121
99 self.AddStories(['easy_ttfmp'], [ 122 self.AddStories(['easy_ttfmp'], [
100 'http://www.slideshare.net', 123 ('http://www.slideshare.net', 'slideshare.net'),
101 'http://www.bradesco.com.br', 124 ('http://www.bradesco.com.br', 'bradesco.com.br'),
102 'http://www.gsshop.com', 125 ('http://www.gsshop.com', 'gsshop.com'),
103 # Disabled to avoid Nexus5X bot timeout crbug.com/702175 126 # Disabled to avoid Nexus5X bot timeout crbug.com/702175
104 # 'http://www.sbs.co.kr', 127 # ('http://www.sbs.co.kr', 'sbs.co.kr'),
105 # 'http://www.futura-sciences.com', 128 # ('http://www.futura-sciences.com', 'futura-sciences.com'),
106 ], cache_temperatures, traffic_settings) 129 ], cache_temperatures, traffic_settings)
107 130
108 self.AddStories(['tough_tti'], [ 131 self.AddStories(['tough_tti'], [
109 'http://www.thestar.com.my', 132 ('http://www.thestar.com.my', 'thestar.com.my'),
110 'http://www.58pic.com', 133 ('http://www.58pic.com', '58pic.com'),
111 'http://www.hongkiat.com', 134 ('http://www.hongkiat.com', 'hongkiat.com'),
112 # Disabled to avoid Nexus5X bot timeout crbug.com/702175 135 # Disabled to avoid Nexus5X bot timeout crbug.com/702175
113 # 'http://www.ebs.in', 136 # ('http://www.ebs.in', 'ebs.in'),
114 # 'http://www.ibicn.com', 137 # ('http://www.ibicn.com', 'ibicn.com'),
115 ], cache_temperatures, traffic_settings) 138 ], cache_temperatures, traffic_settings)
116 139
117 self.AddStories(['easy_tti'], [ 140 self.AddStories(['easy_tti'], [
118 'http://www.dramaq.com.tw', 141 ('http://www.dramaq.com.tw', 'dramaq.com.tw'),
119 'http://www.locanto.in', 142 ('http://www.locanto.in', 'locanto.in'),
120 'http://www.francetvinfo.fr', 143 ('http://www.francetvinfo.fr', 'francetvinfo.fr'),
121 # Disabled to avoid Nexus5X bot timeout crbug.com/702175 144 # Disabled to avoid Nexus5X bot timeout crbug.com/702175
122 # 'http://www.gfk.com', 145 # ('http://www.gfk.com', 'gfk.com'),
123 # 'http://www.mlsmatrix.com' 146 # ('http://www.mlsmatrix.com' 'mlsmatrix.com'),
124 ], cache_temperatures, traffic_settings) 147 ], cache_temperatures, traffic_settings)
125 148
126 def AddStories(self, tags, urls, cache_temperatures, traffic_settings): 149 def AddStories(self, tags, urls, cache_temperatures, traffic_settings):
127 for url in urls: 150 for url, name in urls:
128 for temp in cache_temperatures: 151 for temp in cache_temperatures:
129 for traffic in traffic_settings: 152 for traffic in traffic_settings:
130 self.AddStory(page_cycler_story.PageCyclerStory(url, self, 153 self.AddStory(page_cycler_story.PageCyclerStory(url, self, name=name,
131 shared_page_state_class=shared_page_state.SharedMobilePageState, 154 shared_page_state_class=shared_page_state.SharedMobilePageState,
132 cache_temperature=temp, traffic_setting=traffic, tags=tags)) 155 cache_temperature=temp, traffic_setting=traffic, tags=tags))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698