Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: build/config/allocator.gni

Issue 2907563002: allocator/Windows: delete the old non-unified allocator-shim (Closed)
Patch Set: remove comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/security_unittest.cc ('k') | chrome/installer/setup/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 6
7 # Temporarily disable tcmalloc on arm64 linux to get rid of compilation errors. 7 # Temporarily disable tcmalloc on arm64 linux to get rid of compilation errors.
8 if (is_android || current_cpu == "mipsel" || is_mac || is_ios || is_asan || 8 if (is_android || current_cpu == "mipsel" || is_mac || is_ios || is_asan ||
9 is_lsan || is_tsan || is_msan || is_win || is_syzyasan || is_fuchsia || 9 is_lsan || is_tsan || is_msan || is_win || is_syzyasan || is_fuchsia ||
10 (is_linux && target_cpu == "arm64")) { 10 (is_linux && target_cpu == "arm64")) {
(...skipping 10 matching lines...) Expand all
21 !is_tsan && !is_msan) { 21 !is_tsan && !is_msan) {
22 _default_use_allocator_shim = true 22 _default_use_allocator_shim = true
23 } else { 23 } else {
24 _default_use_allocator_shim = false 24 _default_use_allocator_shim = false
25 } 25 }
26 26
27 declare_args() { 27 declare_args() {
28 # Memory allocator to use. Set to "none" to use default allocator. 28 # Memory allocator to use. Set to "none" to use default allocator.
29 use_allocator = _default_allocator 29 use_allocator = _default_allocator
30 30
31 # TODO(primiano): this should just become the default without having a flag,
32 # but we need to get there first. http://crbug.com/550886 .
33 # Causes all the allocations to be routed via allocator_shim.cc. 31 # Causes all the allocations to be routed via allocator_shim.cc.
34 use_allocator_shim = _default_use_allocator_shim 32 use_allocator_shim = _default_use_allocator_shim
35 } 33 }
36 34
37 if (is_nacl) { 35 if (is_nacl) {
38 # Turn off the build flag for NaCL builds to minimize confusion, as NaCL 36 # Turn off the build flag for NaCL builds to minimize confusion, as NaCL
39 # doesn't support the heap shim. 37 # doesn't support the heap shim.
40 use_allocator_shim = false 38 use_allocator_shim = false
41 } 39 }
42 40
43 assert(use_allocator == "none" || use_allocator == "tcmalloc") 41 assert(use_allocator == "none" || use_allocator == "tcmalloc")
44 42
45 assert(!is_win || use_allocator == "none", "Tcmalloc doesn't work on Windows.") 43 assert(!is_win || use_allocator == "none", "Tcmalloc doesn't work on Windows.")
46 assert(!is_mac || use_allocator == "none", "Tcmalloc doesn't work on macOS.") 44 assert(!is_mac || use_allocator == "none", "Tcmalloc doesn't work on macOS.")
47 45
48 assert( 46 assert(
49 !use_allocator_shim || is_linux || is_android || is_win || is_mac, 47 !use_allocator_shim || is_linux || is_android || is_win || is_mac,
50 "use_allocator_shim is supported only on Linux, Android, Windows and macOS t argets") 48 "use_allocator_shim is supported only on Linux, Android, Windows and macOS t argets")
51 49
52 if (is_win && use_allocator_shim) { 50 if (is_win && use_allocator_shim) {
53 assert(!is_component_build, 51 assert(!is_component_build,
54 "The allocator shim doesn't work for the component build on Windows.") 52 "The allocator shim doesn't work for the component build on Windows.")
55 } 53 }
OLDNEW
« no previous file with comments | « base/security_unittest.cc ('k') | chrome/installer/setup/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698