Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2907533002: [MD Bookmarks] Fix JS closure compile for paper-toast. (Closed)

Created:
3 years, 7 months ago by calamity
Modified:
3 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Fix JS closure compile for paper-toast. This CL fixes a case with the closure script where concatenating IronOverlayBehavior before an IIFE would cause the compile to fail because IronOverlayBehavior ends with an @param declaration which is expected to be true of the first thing in the next file. This has been fixed by adding a jsdoc comment between concatenated files. BUG=725786 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
calamity
Hey, You can patch in https://codereview.chromium.org/2898303004/ to see in what way the compiler breaks. PTAL, ...
3 years, 7 months ago (2017-05-25 07:38:22 UTC) #3
Dan Beam
hmmmmmm what's the expanded code look like? isn't this a legit problem if we were ...
3 years, 6 months ago (2017-05-30 23:32:58 UTC) #4
calamity
On 2017/05/30 23:32:58, Dan Beam wrote: > hmmmmmm > > what's the expanded code look ...
3 years, 6 months ago (2017-05-31 02:58:23 UTC) #5
Dan Beam
3 years, 6 months ago (2017-06-06 02:18:32 UTC) #6
still need this?

Powered by Google App Engine
This is Rietveld 408576698