chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc - Issue 2907493002: ChromeOS: Per-user time zone: refactor tests first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc

Issue 2907493002: ChromeOS: Per-user time zone: refactor tests first. (Closed)

Patch Set: Fix debug build Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc ('k') | chrome/browser/chromeos/file_manager/path_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc

diff --git a/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc b/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc

index 56b71b154586c33718caa0508f4e666982827a1c..4539fa28f664333694bf9e2a6f5b5c6ee3151b2b 100644

--- a/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc

+++ b/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc

@@ -119,7 +119,7 @@ class PublicSessionPermissionHelperTest

std::vector<PermissionIDSet> allowed_permissions_;

- chromeos::ScopedTestPublicSessionLoginState login_state_;

+ std::unique_ptr<chromeos::ScopedTestPublicSessionLoginState> login_state_;

private:

DISALLOW_COPY_AND_ASSIGN(PublicSessionPermissionHelperTest);

@@ -127,11 +127,13 @@ class PublicSessionPermissionHelperTest

void PublicSessionPermissionHelperTest::SetUp() {

ChromeRenderViewHostTestHarness::SetUp();

+ login_state_.reset(new chromeos::ScopedTestPublicSessionLoginState());

extension_a_ = LoadManifestHelper("extension_a");

extension_b_ = LoadManifestHelper("extension_b");

}

void PublicSessionPermissionHelperTest::TearDown() {

+ login_state_.reset();

ResetPermissionsForTesting();

ChromeRenderViewHostTestHarness::TearDown();

}