chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc - Issue 2907493002: ChromeOS: Per-user time zone: refactor tests first.

Side by Side Diff: chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

Issue 2907493002: ChromeOS: Per-user time zone: refactor tests first. (Closed)

Patch Set: Update after review. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/chromeos/scoped_sys_info_chromeos_version_for_testing.cc ('K') | « chrome/browser/notifications/platform_notification_service_unittest.cc ('k') | chrome/browser/ui/webui/options/preferences_browsertest.cc » ('j') | chrome/browser/ui/webui/options/preferences_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <stddef.h>	5 #include <stddef.h>

6	6

7 #include "base/compiler_specific.h"	7 #include "base/compiler_specific.h"

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/memory/ptr_util.h"	9 #include "base/memory/ptr_util.h"

10 #include "base/strings/stringprintf.h"	10 #include "base/strings/stringprintf.h"

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71 }	71 }

72 };	72 };

73	73

74 struct PrefTest {	74 struct PrefTest {

75 const char* pref_name;	75 const char* pref_name;

76 bool owner_only;	76 bool owner_only;

77 bool indicator;	77 bool indicator;

78 };	78 };

79	79

80 const PrefTest kPrefTests[] = {	80 const PrefTest kPrefTests[] = {

81 { kSystemTimezone, false, false },
xiyuan 2017/05/26 17:14:53 This seems not related with the CL. This seems not related with the CL. Alexander Alekseev 2017/05/26 18:06:21 Done. Show quoted text On 2017/05/26 17:14:53, xiyuan wrote: > This seems not related with the CL. Done.
82 { prefs::kUse24HourClock, false, false },	81 { prefs::kUse24HourClock, false, false },

83 { kAttestationForContentProtectionEnabled, true, true },	82 { kAttestationForContentProtectionEnabled, true, true },

84 { kAccountsPrefAllowGuest, true, false },	83 { kAccountsPrefAllowGuest, true, false },

85 { kAccountsPrefAllowNewUser, true, false },	84 { kAccountsPrefAllowNewUser, true, false },

86 { kAccountsPrefShowUserNamesOnSignIn, true, false },	85 { kAccountsPrefShowUserNamesOnSignIn, true, false },

87 { kAccountsPrefSupervisedUsersEnabled, true, false },	86 { kAccountsPrefSupervisedUsersEnabled, true, false },

88 #if defined(GOOGLE_CHROME_BUILD)	87 #if defined(GOOGLE_CHROME_BUILD)

89 { kStatsReportingPref, true, true },	88 { kStatsReportingPref, true, true },

90 { spellcheck::prefs::kSpellCheckUseSpellingService, false, false },	89 { spellcheck::prefs::kSpellCheckUseSpellingService, false, false },

91 #endif	90 #endif

(...skipping 366 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
458 content::WaitForLoadStop(contents);	457 content::WaitForLoadStop(contents);

459 {	458 {

460 SCOPED_TRACE("Screen lock false for both users");	459 SCOPED_TRACE("Screen lock false for both users");

461 expected_value = false;	460 expected_value = false;

462 CheckBooleanPreference(contents, prefs::kEnableAutoScreenLock, disabled,	461 CheckBooleanPreference(contents, prefs::kEnableAutoScreenLock, disabled,

463 empty_controlled, expected_value);	462 empty_controlled, expected_value);

464 }	463 }

465 }	464 }

466	465

467 } // namespace chromeos	466 } // namespace chromeos

OLD	NEW