ChromeOS: Per-user time zone: refactor tests first.

chrome/browser/notifications/extension_welcome_notification_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/extension_welcome_notification.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
@@ skipping 121 matching lines @@
   ExtensionWelcomeNotificationTest() {
     scoped_refptr<user_prefs::PrefRegistrySyncable> pref_registry(
         new user_prefs::PrefRegistrySyncable());
     ExtensionWelcomeNotification::RegisterProfilePrefs(pref_registry.get());
   }
 
   void SetUp() override {
     task_runner_ = new base::TestSimpleTaskRunner();
     base::MessageLoop::current()->SetTaskRunner(task_runner_);
     profile_.reset(new TestingProfile());
+    task_runner()->RunUntilIdle();
     delegate_ = new WelcomeNotificationDelegate();
     welcome_notification_.reset(
         ExtensionWelcomeNotification::Create(profile_.get(), delegate_));
   }
 
   void TearDown() override {
     delegate_ = NULL;
     welcome_notification_.reset();
     profile_.reset();
     TestingBrowserProcess::DeleteInstance();
@@ skipping 377 matching lines @@
 
   EXPECT_FALSE(task_runner()->HasPendingTask());
   EXPECT_EQ(message_center()->add_notification_calls(), 0);
   EXPECT_EQ(message_center()->remove_notification_calls(), 0);
   EXPECT_EQ(message_center()->notifications_with_shown_as_popup(), 0);
   EXPECT_FALSE(GetBooleanPref(prefs::kWelcomeNotificationDismissed));
   EXPECT_TRUE(GetBooleanPref(prefs::kWelcomeNotificationDismissedLocal));
   EXPECT_TRUE(GetBooleanPref(prefs::kWelcomeNotificationPreviouslyPoppedUp));
   EXPECT_EQ(GetInt64Pref(prefs::kWelcomeNotificationExpirationTimestamp), 1);
 }