ChromeOS: Per-user time zone: refactor tests first.

chrome/browser/chromeos/file_manager/path_util_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_manager/path_util.h"
 
 #include "base/files/file_path.h"
+#include "base/sys_info.h"
 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace file_manager {
 namespace util {
 namespace {
 
+const char kLsbRelease[] =
+    "CHROMEOS_RELEASE_NAME=Chrome OS\n"
+    "CHROMEOS_RELEASE_VERSION=1.2.3.4\n";
+
+// Sets a valid Chrome  OS version info so IsRunningOnChromeOS() returns true.

[stevenjb, 2017/05/25 21:20:24]

This is a bit subtle, can you explain a little why we need to do this, or
reference an issue?

[Alexander Alekseev, 2017/05/26 02:18:01]

Done. (See below.)

+class ScopedSetRunningOnChromeOS {
+ public:
+  ScopedSetRunningOnChromeOS(const std::string& lsb_release,
+                             const base::Time& lsb_release_time) {
+    base::SysInfo::SetChromeOSVersionInfoForTest(lsb_release, lsb_release_time);
+  }
+  ~ScopedSetRunningOnChromeOS() {
+    base::SysInfo::SetChromeOSVersionInfoForTest("", base::Time());
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ScopedSetRunningOnChromeOS);
+};
+
 TEST(FileManagerPathUtilTest, MultiProfileDownloadsFolderMigration) {
   content::TestBrowserThreadBundle thread_bundle;
   TestingProfile profile;
+  ScopedSetRunningOnChromeOS fake_release(kLsbRelease, base::Time());
 
   // This looks like "/home/chronos/u-hash/Downloads" in the production
   // environment.
   const base::FilePath kDownloads = GetDownloadsFolderForProfile(&profile);
   const base::FilePath kOldDownloads =
       DownloadPrefs::GetDefaultDownloadDirectory();
 
   base::FilePath path;
 
   EXPECT_TRUE(MigratePathFromOldFormat(&profile, kOldDownloads, &path));
@@ skipping 62 matching lines @@
   // Non-primary profile's downloads folder is not supported for ARC yet.
   const base::FilePath downloads2 = GetDownloadsFolderForProfile(
       chromeos::ProfileHelper::Get()->GetProfileByUserIdHash(
           "user2@gmail.com-hash"));
   EXPECT_FALSE(ConvertPathToArcUrl(downloads2.AppendASCII("a/b/c"), &url));
 }
 
 }  // namespace
 }  // namespace util
 }  // namespace file_manager