Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2668)

Unified Diff: base/path_service_unittest.cc

Issue 2907473002: fuchsia: add base_paths_fuchsia.cc (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/path_service.cc ('K') | « base/path_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/path_service_unittest.cc
diff --git a/base/path_service_unittest.cc b/base/path_service_unittest.cc
index 599da000a9b3ba52e7cfca4f9716ba3c366fcb1e..d86bc0f92917f6f1db077d93865cbfb005cd948b 100644
--- a/base/path_service_unittest.cc
+++ b/base/path_service_unittest.cc
@@ -30,7 +30,7 @@ bool ReturnsValidPath(int dir_type) {
// Some paths might not exist on some platforms in which case confirming
// |result| is true and !path.empty() is the best we can do.
bool check_path_exists = true;
-#if defined(OS_POSIX)
+#if defined(OS_POSIX) && !defined(OS_FUCHSIA)
Lei Zhang 2017/05/24 23:28:34 Are we going to eventually testing Fuchsia here? D
scottmg 2017/05/24 23:42:29 This should test all paths that go through here, r
// If chromium has never been started on this account, the cache path may not
// exist.
if (dir_type == DIR_CACHE)
@@ -115,7 +115,7 @@ TEST_F(PathServiceTest, Get) {
++key) {
EXPECT_PRED1(ReturnsValidPath, key);
}
-#elif defined(OS_POSIX)
+#elif defined(OS_POSIX) && !defined(OS_FUCHSIA)
scottmg 2017/05/24 23:42:29 This part just avoids testing the POSIX_ specific
for (int key = PATH_POSIX_START + 1; key < PATH_POSIX_END;
++key) {
EXPECT_PRED1(ReturnsValidPath, key);
« base/path_service.cc ('K') | « base/path_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698