Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5637)

Unified Diff: chrome/browser/io_thread.cc

Issue 2907463002: Split HttpNetworkSession::Params into two structs. (Closed)
Patch Set: Fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 019e63e38a510b86bb516274c8b102ee72c3a205..764ec8d09d23753dabbfcd8337d15ebc3d0b8de4 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -632,10 +632,10 @@ void IOThread::Init() {
command_line.GetSwitchValueASCII(switches::kHostRules));
TRACE_EVENT_END0("startup", "IOThread::InitAsync:SetRulesFromString");
}
- params_.host_mapping_rules = *globals_->host_mapping_rules.get();
+ session_params_.host_mapping_rules = *globals_->host_mapping_rules.get();
globals_->enable_brotli =
base::FeatureList::IsEnabled(features::kBrotliEncoding);
- params_.enable_token_binding =
+ session_params_.enable_token_binding =
base::FeatureList::IsEnabled(features::kTokenBinding);
// Check for OS support of TCP FastOpen, and turn it on for all connections if
@@ -649,7 +649,7 @@ void IOThread::Init() {
ConfigureParamsFromFieldTrialsAndCommandLine(
command_line, is_quic_allowed_by_policy_,
- http_09_on_non_default_ports_enabled_, &params_);
+ http_09_on_non_default_ports_enabled_, &session_params_);
#if defined(OS_MACOSX)
// Start observing Keychain events. This needs to be done on the UI thread,
@@ -791,11 +791,11 @@ void IOThread::ClearHostCache(
}
const net::HttpNetworkSession::Params& IOThread::NetworkSessionParams() const {
- return params_;
+ return session_params_;
}
void IOThread::DisableQuic() {
- params_.enable_quic = false;
+ session_params_.enable_quic = false;
if (globals_->system_request_context_storage)
globals_->system_request_context_storage->http_network_session()
@@ -891,6 +891,7 @@ void IOThread::ConstructSystemRequestContext() {
context->set_cert_verifier(globals_->cert_verifier.get());
context->set_cert_transparency_verifier(
globals_->cert_transparency_verifier.get());
+
context_storage->set_ct_policy_enforcer(
base::MakeUnique<net::CTPolicyEnforcer>());
@@ -901,12 +902,13 @@ void IOThread::ConstructSystemRequestContext() {
std::move(system_proxy_config_service_), command_line,
WpadQuickCheckEnabled(), PacHttpsUrlStrippingEnabled()));
- net::HttpNetworkSession::Params system_params(params_);
+ net::HttpNetworkSession::Context session_context;
net::URLRequestContextBuilder::SetHttpNetworkSessionComponents(
- context, &system_params);
+ context, &session_context);
context_storage->set_http_network_session(
- base::MakeUnique<net::HttpNetworkSession>(system_params));
+ base::MakeUnique<net::HttpNetworkSession>(session_params_,
+ session_context));
context_storage->set_http_transaction_factory(
base::MakeUnique<net::HttpNetworkLayer>(
context_storage->http_network_session()));

Powered by Google App Engine
This is Rietveld 408576698