third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-sync-iframe.html - Issue 2907443002: Upstream service worker "XHR" test to WPT

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-sync-iframe.html

Issue 2907443002: Upstream service worker "XHR" test to WPT (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr-sync.https.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr-sync.https-expected.txt ('k') | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-sync-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-sync-iframe.html

diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-sync-iframe.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-sync-iframe.html

new file mode 100644

index 0000000000000000000000000000000000000000..657596e3a5cf30fda2959d46d7c62e4e7840b34c

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-xhr-sync-iframe.html

@@ -0,0 +1,16 @@

+<!DOCTYPE html>

+<title>Service Worker: Synchronous XHR doesn't deadlock iframe</title>

mike3 2017/05/29 16:14:21 I'll also remove the reference to "blocking" from

+<script>

+'use strict';

+function performSyncXHR() {

+ var url = 'fetch-request-xhr-sync-data.txt?bustcache=' + Date.now();

+ var syncXhr = new XMLHttpRequest();

+ syncXhr.open('GET', url, false);

+ syncXhr.send();

+ if (syncXhr.responseText != 'hello') {

+ throw 'FAIL';

falken 2017/05/29 04:22:15 just for expectation hardening, can you include th

mike3 2017/05/29 16:14:21 Sure. I've refactored this to return the value of

falken 2017/05/30 01:08:41 Good point, I think you're right: my suggestion ma

Good point, I think you're right: my suggestion made the test more fragile. I can think of some approaches: (1) Go back to the first approach where we just test for the expected string. (Would prefer using 'PASS' instead of 'hello' though.) (2) Add the server-side file with 'FAIL: service worker did not intercept the request' as the response text, instead of relying on 404 from WPT. (3) Use assert_equals on response status code instead of response text. I kind of think (2) makes the test easiest to understand, but may be overkill. I think (3) should be fairly simple and robust. WDYT?

+ }

+</script>