third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr-sync.https.html - Issue 2907443002: Upstream service worker "XHR" test to WPT

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr-sync.https.html

Issue 2907443002: Upstream service worker "XHR" test to WPT (Closed)

Patch Set: Improve test design Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-xhr-sync.https-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Service Worker: Synchronous XHR is intercepted</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script src="resources/test-helpers.sub.js"></script>

	6 <script>

	7 'use strict';

	8

	9 promise_test(function(t) {

	10 var url = 'resources/fetch-request-xhr-sync-worker.js';

	11 var scope = 'resources/fetch-request-xhr-sync-iframe.html';

	12 var non_existent_file = 'non-existent-file.txt?bustcache=' + Date.now();
	falken 2017/06/01 03:57:11 By the way: do you know why this bustcache= thing By the way: do you know why this bustcache= thing is needed? I don't know why it was in the original test. We seem to not use this technique in other tests. If you don't know either, I think we can just remove it. mike3 2017/06/01 15:01:04 Now that you mention it, it looks like a vestige o Show quoted text On 2017/06/01 03:57:11, falken wrote: > By the way: do you know why this bustcache= thing is needed? I don't know why it > was in the original test. We seem to not use this technique in other tests. If > you don't know either, I think we can just remove it. Now that you mention it, it looks like a vestige of the original (erroneous) factoring. Removing...
	13

	14 return service_worker_unregister_and_register(t, url, scope)

	15 .then(function(registration) {

	16 t.add_cleanup(function() {

	17 registration.unregister();

	18 });

	19

	20 return wait_for_state(t, registration.installing, 'activated');

	21 })

	22 .then(function() { return with_iframe(scope); })

	23 .then(function(frame) {

	24 t.add_cleanup(function() {

	25 frame.remove();

	26 });

	27

	28 return new Promise(function(resolve, reject) {

	29 setTimeout(function() {

	30 var xhr;

	31 try {

	32 xhr = frame.contentWindow.performSyncXHR(non_existent_file);

	33 resolve(xhr);

	34 } catch (err) {

	35 reject(err);

	36 }

	37 }, 0);

	38 })

	39 })

	40 .then(function(xhr) {

	41 assert_equals(

	42 xhr.status,

	43 200,

	44 'HTTP response status code for intercepted request'

	45 );

	46 assert_equals(

	47 xhr.responseText,

	48 'Response from service worker',

	49 'HTTP response text for intercepted request'

	50 );

	51 });

	52 }, 'Verify SyncXHR is intercepted');

	53 </script>

OLD	NEW