Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: tests/standalone/io/test_runner_test.dart

Issue 2907403005: Fix static error in test_runner_test. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/test_runner_test.dart
diff --git a/tests/standalone/io/test_runner_test.dart b/tests/standalone/io/test_runner_test.dart
index 90920e93221eaf8283734543501ea4c7198eee8c..2b13cdaa2a8aac05a6f0035e08de0356109ce4da 100644
--- a/tests/standalone/io/test_runner_test.dart
+++ b/tests/standalone/io/test_runner_test.dart
@@ -69,7 +69,7 @@ class TestController {
class CustomTestSuite extends TestSuite {
CustomTestSuite(Map configuration) : super(configuration, "CustomTestSuite");
- void forEachTest(TestCaseEvent onTest, Map testCache, [onDone]) {
+ Future forEachTest(TestCaseEvent onTest, Map testCache, [onDone]) {
void enqueueTestCase(testCase) {
TestController.numTests++;
onTest(testCase);
@@ -91,6 +91,8 @@ class CustomTestSuite extends TestSuite {
if (onDone != null) {
onDone();
}
+
+ return null;
Paul Berry 2017/05/30 22:26:29 It's not obvious why this is ok. Can we add a com
}
TestCase _makeNormalTestCase(name, expectations) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698