Issue 2907403005: Fix static error in test_runner_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2907403005: Fix static error in test_runner_test. (Closed)

Created:
3 years, 6 months ago by Bob Nystrom

Modified:
3 years, 6 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix static error in test_runner_test. Committed: https://github.com/dart-lang/sdk/commit/027eaca77ede18dd38b98254c1da62b03152f005

Patch Set 1 #

Total comments: 1

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tests/standalone/io/test_runner_test.dart	View		2 chunks	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

Committed patchset #1 (id:1) manually as 027eaca77ede18dd38b98254c1da62b03152f005 (presubmit successful).

3 years, 6 months ago (2017-05-30 22:25:58 UTC) #5

Paul Berry

3 years, 6 months ago (2017-05-30 22:26:29 UTC) #6

Message was sent while issue was closed.

lgtm assuming the issue below is addressed

https://codereview.chromium.org/2907403005/diff/1/tests/standalone/io/test_ru...
File tests/standalone/io/test_runner_test.dart (right):

https://codereview.chromium.org/2907403005/diff/1/tests/standalone/io/test_ru...
tests/standalone/io/test_runner_test.dart:95: return null;
It's not obvious why this is ok.  Can we add a comment saying something like
"the test framework doesn't use the return value"?

Alternatively, just return `new Future.value()`.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages