Don't tag fromEnvironment constructors as native

Don't tag fromEnvironment constructors as native

+ enable buildbot testing of closed_world_from_dill

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/f6dcc2ef4f1af3552d30604ce0fbc3efbc594ce0

[Johnni Winther, 2017-05-30 11:40:04]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-30 22:11:52]

lgtm

[Siggi Cherem (dart-lang), 2017-05-30 22:17:57]

https://codereview.chromium.org/2907383002/diff/20001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/native.dart (right):

https://codereview.chromium.org/2907383002/diff/20001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/native.dart:29: bool maybeEnableNative(LibraryEntity
library,
Could we change this to just take the Uri instead?

I have a change in front-end/fasta in flight to make it more flexible about
where it allows the native keyword. Right now it only allows it within core
libs, but I'm changing it so we can override this in the dart2js target.

(see https://codereview.chromium.org/2913013003/ for details).

I now realize that once we want to use fasta in-memory (and not load just the
.dill file), then we'll likely need to have this exact logic as well. If we
switch the API to only expect a URI, then I can use it directly.

[Johnni Winther, 2017-05-31 08:40:01]

https://codereview.chromium.org/2907383002/diff/20001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/native.dart (right):

https://codereview.chromium.org/2907383002/diff/20001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/native.dart:29: bool maybeEnableNative(LibraryEntity
library,
On 2017/05/30 22:17:56, Siggi Cherem (dart-lang) wrote:
> Could we change this to just take the Uri instead?
> 
> I have a change in front-end/fasta in flight to make it more flexible about
> where it allows the native keyword. Right now it only allows it within core
> libs, but I'm changing it so we can override this in the dart2js target.
> 
> (see https://codereview.chromium.org/2913013003/ for details).
> 
> I now realize that once we want to use fasta in-memory (and not load just the
> .dill file), then we'll likely need to have this exact logic as well. If we
> switch the API to only expect a URI, then I can use it directly.

Done.

[Johnni Winther, 2017-05-31 08:45:03]

Description was changed from

==========
Don't tag fromEnvironment constructors as native

+ enable buildbot testing of closed_world_from_dill
==========

to

==========
Don't tag fromEnvironment constructors as native

+ enable buildbot testing of closed_world_from_dill

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f6dcc2ef4f1af3552d30604ce0fbc3efbc594ce0
==========

[Johnni Winther, 2017-05-31 08:45:04]

Committed patchset #3 (id:40001) manually as
f6dcc2ef4f1af3552d30604ce0fbc3efbc594ce0 (presubmit successful).