Use entities for globals in Namer.

Use entities for globals in Namer.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/44580b201e74109005ab61b2d0742aa873bb54e6

[Johnni Winther, 2017-05-30 11:09:40]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-30 21:37:20]

lgtm

https://codereview.chromium.org/2907373002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://codereview.chromium.org/2907373002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/namer.dart:898: /*jsAst.Name
_globalPropertyName(Element element) {
delete?

https://codereview.chromium.org/2907373002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/namer.dart:1049: if (element is Element) {
TODO to ensure we work with declarations all the time?

[Johnni Winther, 2017-05-31 07:57:06]

https://codereview.chromium.org/2907373002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://codereview.chromium.org/2907373002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/namer.dart:898: /*jsAst.Name
_globalPropertyName(Element element) {
On 2017/05/30 21:37:20, Siggi Cherem (dart-lang) wrote:
> delete?

Done.

https://codereview.chromium.org/2907373002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/namer.dart:1049: if (element is Element) {
On 2017/05/30 21:37:20, Siggi Cherem (dart-lang) wrote:
> TODO to ensure we work with declarations all the time?

J/K-Elements are only declaration elements. Added a comment.

[Johnni Winther, 2017-05-31 08:02:59]

Description was changed from

==========
Use entities for globals in Namer.
==========

to

==========
Use entities for globals in Namer.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/44580b201e74109005ab61b2d0742aa873bb54e6
==========

[Johnni Winther, 2017-05-31 08:03:00]

Committed patchset #2 (id:20001) manually as
44580b201e74109005ab61b2d0742aa873bb54e6 (presubmit successful).