Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2907333003: Fix performance regression for checking that retricted types are not (Closed)

Created:
3 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix performance regression for checking that retricted types are not extended/implemented. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/922326a91f215142f92bb5dba52f001d307c44ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M pkg/compiler/lib/src/kernel/fasta_support.dart View 4 chunks +34 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-05-30 21:16:41 UTC) #2
ahe
lgtm Thank you. Nice!
3 years, 6 months ago (2017-05-31 09:17:38 UTC) #3
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-05-31 21:07:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
922326a91f215142f92bb5dba52f001d307c44ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698