Use multi-value switch to enable/disable the unified gesture detector.

ui/events/gestures/gesture_recognizer_impl.cc

Index: ui/events/gestures/gesture_recognizer_impl.cc
diff --git a/ui/events/gestures/gesture_recognizer_impl.cc b/ui/events/gestures/gesture_recognizer_impl.cc
index d2316d4d0ca9555d489906dda27a9027e4b067cb..28e50476ddccfe8b2500c5795183a6df751ae20e 100644
--- a/ui/events/gestures/gesture_recognizer_impl.cc
+++ b/ui/events/gestures/gesture_recognizer_impl.cc
@@ -68,9 +68,27 @@ GestureProviderAura* CreateGestureProvider(GestureProviderAuraClient* client) {
 ////////////////////////////////////////////////////////////////////////////////
 // GestureRecognizerImpl, public:
 
-GestureRecognizerImpl::GestureRecognizerImpl()
-    : use_unified_gesture_detector_(CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kUseUnifiedGestureDetector)) {
+GestureRecognizerImpl::GestureRecognizerImpl() {
+  // Default to not using the unified gesture detector.
+  const CommandLine& command_line = *CommandLine::ForCurrentProcess();
+  const std::string unified_gr_enabled_switch =
+      command_line.HasSwitch(switches::kUnifiedGestureDetector) ?
+      command_line.GetSwitchValueASCII(switches::kUnifiedGestureDetector) :
+      switches::kUnifiedGestureDetectorAuto;
+
+  if (unified_gr_enabled_switch.empty() ||
+      unified_gr_enabled_switch == switches::kUnifiedGestureDetectorEnabled) {
+    use_unified_gesture_detector_ = true;
+  } else if (unified_gr_enabled_switch ==
+                 switches::kUnifiedGestureDetectorAuto ||
+             unified_gr_enabled_switch ==
+                 switches::kUnifiedGestureDetectorDisabled) {
+    use_unified_gesture_detector_ = false;

[sadrul, 2014/05/22 18:45:25]

Can you do:

  const bool kUseUnifiedDefault = false;
  if (switch empty or enabled) use_unified = true;
  else if (switch disabled) use_unified = false;
  else use_unified = kUseUnifiedDefault;

That way, switching the default would involve changing just the const bool's
value.
  

[tdresser, 2014/05/22 19:13:04]

Done.

+  } else {
+    LOG(ERROR) << "Invalid --unified-gesture-detector option: "
+               << unified_gr_enabled_switch;
+    use_unified_gesture_detector_ = false;
+  }
 }
 
 GestureRecognizerImpl::~GestureRecognizerImpl() {