src/objects.h - Issue 290733008: Teach OrderedHashSet::Remove to report whether it actually removed anything

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 290733008: Teach OrderedHashSet::Remove to report whether it actually removed anything (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 80848f882bd5e38dd185a4d6d4f9bf0a474f4a67..944efb9d5e70b5c3289424db51b747469812f9c4 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -4323,7 +4323,7 @@ class OrderedHashSet: public OrderedHashTable<

static Handle<OrderedHashSet> Add(

Handle<OrderedHashSet> table, Handle<Object> key);

static Handle<OrderedHashSet> Remove(

- Handle<OrderedHashSet> table, Handle<Object> key);

+ Handle<OrderedHashSet> table, Handle<Object> key, bool* was_present);

};

« no previous file with comments | « src/collection.js ('k') | src/objects.cc » ('j') | no next file with comments »