Issue 290733008: Teach OrderedHashSet::Remove to report whether it actually removed anything

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 290733008: Teach OrderedHashSet::Remove to report whether it actually removed anything (Closed)

Created:
6 years, 7 months ago by adamk

Modified:
6 years, 7 months ago

Reviewers:
arv (Not doing code reviews), Michael Starzinger

CC:
v8-dev, rossberg

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Teach OrderedHashSet::Remove to report whether it actually removed anything This avoids an unnecessary runtime call from Set.prototype.delete(). R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21408

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -16 lines)			Patch
M	src/collection.js	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	test/cctest/test-ordered-hash-table.cc	View	2 chunks	+15 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

adamk

Committed patchset #1 manually as r21408 (presubmit successful).

6 years, 7 months ago (2014-05-21 12:16:55 UTC) #3

Message was sent while issue was closed.

LGTM