Don't spin the loading indicator for in-page navigations.

content/public/browser/web_contents.h

Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 38830c3a86cbf2a8cfa0ed931e21c698c4238053..81c2ad32dab68bdad27e9e0c824e0080c03a5b07 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -258,25 +258,29 @@ class WebContents : public PageNavigator,
   // returns the current SiteInstance.
   virtual SiteInstance* GetPendingSiteInstance() const = 0;
 
-  // Return whether this WebContents is loading a resource.
+  // Returns whether this WebContents is loading a resource.
   virtual bool IsLoading() const = 0;
 
+  // Returns whether the current load is to a different document. Only valid
+  // if IsLoading() returns true.
+  virtual bool IsLoadToDifferentDocument() const = 0;

[Nico, 2014/05/20 21:25:31]

All callers of this check for `IsLoading() && IsLoadToDifferentDocument()`.
Should this be IsLoadingToDifferentDocument() and only return true if
IsLoading() returns true too? Then you don't need to duplicate that and in many
places.

[Avi (use Gerrit), 2014/05/20 22:00:42]

That's actually not true; IsWaitingForResponse is gated as well. Then again, no
one uses IsWaitingForResponse except along with IsLoadToDifferentDocument.

+
   // Returns whether this WebContents is waiting for a first-response for the
   // main resource of the page.
   virtual bool IsWaitingForResponse() const = 0;
 
-  // Return the current load state and the URL associated with it.
+  // Returns the current load state and the URL associated with it.
   virtual const net::LoadStateWithParam& GetLoadState() const = 0;
   virtual const base::string16& GetLoadStateHost() const = 0;
 
-  // Return the upload progress.
+  // Returns the upload progress.
   virtual uint64 GetUploadSize() const = 0;
   virtual uint64 GetUploadPosition() const = 0;
 
   // Returns a set of the site URLs currently committed in this tab.
   virtual std::set<GURL> GetSitesInTab() const = 0;
 
-  // Return the character encoding of the page.
+  // Returns the character encoding of the page.
   virtual const std::string& GetEncoding() const = 0;
 
   // True if this is a secure page which displayed insecure content.