Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2782)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 290733004: Don't spin the loading indicator for in-page navigations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
index b89ffb1fd753decb8b3552a601d9d615dfc7941f..08f2e1bfccd57fc48e342f8219b571e36107ab95 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
@@ -1576,10 +1576,12 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {
if (contents->IsCrashed()) {
newState = kTabCrashed;
newHasIcon = true;
- } else if (contents->IsWaitingForResponse()) {
+ } else if (contents->IsWaitingForResponse() &&
+ contents->IsLoadToDifferentDocument()) {
newState = kTabWaiting;
throbberImage = throbberWaitingImage;
- } else if (contents->IsLoading()) {
+ } else if (contents->IsLoading() &&
+ contents->IsLoadToDifferentDocument()) {
newState = kTabLoading;
throbberImage = throbberLoadingImage;
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc » ('j') | content/public/browser/web_contents.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698