Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 290723002: Fix Android build breakage with new extension tests (Closed)

Created:
6 years, 7 months ago by trchen
Modified:
6 years, 7 months ago
Reviewers:
mek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix Android build breakage with new extension tests The tests use EXPECT_EQ with a constant variable equal to false, that tricks GCC 4.7+ into beliving the variable should be compatible to null pointers in some internal macro. This CL workarounds that by using EXPECT_TRUE(a == b) instead. BUG=https://code.google.com/p/googletest/issues/detail?id=458 TBR=mek NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
trchen
The CQ bit was checked by trchen@chromium.org
6 years, 7 months ago (2014-05-16 23:43:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/290723002/1
6 years, 7 months ago (2014-05-16 23:45:24 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 01:14:23 UTC) #3
Message was sent while issue was closed.
Change committed as 271136

Powered by Google App Engine
This is Rietveld 408576698