Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2907213002: [Extract Method] When no selection, check for implicitly selected closure. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Extract Method] When no selection, check for implicitly selected closure. R=brianwilkerson@google.com, devoncarew@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9737664106e2602b18ad46c84c105ae3ee79d41c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -18 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 3 chunks +91 lines, -18 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 6 months ago (2017-05-29 18:12:48 UTC) #1
Brian Wilkerson
lgtm
3 years, 6 months ago (2017-05-30 02:50:48 UTC) #2
scheglov
3 years, 6 months ago (2017-05-30 18:11:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9737664106e2602b18ad46c84c105ae3ee79d41c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698