Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Unified Diff: runtime/bin/main.cc

Issue 290713004: First step towards asynchronous loading of sources (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
===================================================================
--- runtime/bin/main.cc (revision 36574)
+++ runtime/bin/main.cc (working copy)
@@ -544,20 +544,11 @@
IsolateData* isolate_data = reinterpret_cast<IsolateData*>(data);
ASSERT(isolate_data != NULL);
ASSERT(isolate_data->script_url != NULL);
- Dart_Handle library = DartUtils::LoadScript(isolate_data->script_url,
- builtin_lib);
- CHECK_RESULT(library);
- if (!Dart_IsLibrary(library)) {
- char errbuf[256];
- snprintf(errbuf, sizeof(errbuf),
- "Expected a library when loading script: %s",
- script_uri);
- *error = strdup(errbuf);
- Dart_ExitScope();
- Dart_ShutdownIsolate();
- return NULL;
- }
+ result = DartUtils::LoadScript(isolate_data->script_url, builtin_lib);
+ CHECK_RESULT(result);
+ result = Dart_RunLoop();
+ CHECK_RESULT(result);
Platform::SetPackageRoot(package_root);
Dart_Handle io_lib_url = DartUtils::NewString(DartUtils::kIOLibURL);
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698