Issue 2907093002: Revert "improve fasta unterminated string recovery"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2907093002: Revert "improve fasta unterminated string recovery" (Closed)

Created:
3 years, 6 months ago by danrubel

Modified:
3 years, 6 months ago

Reviewers:

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "improve fasta unterminated string recovery" This reverts commit 6907345fb9323203a5cf78ce9bdc383cf1a299de. Committed: https://github.com/dart-lang/sdk/commit/767d5ecbfd883fcfe506e67511d97f1601f42031

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -235 lines)			Patch
M	pkg/compiler/lib/src/string_validator.dart	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/quote.dart	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart	View	6 chunks	+16 lines, -35 lines	0 comments	Download
M	pkg/front_end/lib/src/scanner/token.dart	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	pkg/front_end/test/scanner_fasta_test.dart	View	4 chunks	+68 lines, -114 lines	0 comments	Download
M	pkg/front_end/test/scanner_replacement_test.dart	View	3 chunks	+42 lines, -0 lines	0 comments	Download
M	pkg/front_end/test/scanner_test.dart	View	5 chunks	+10 lines, -65 lines	0 comments	Download

Total messages: 2 (1 generated)

danrubel

3 years, 6 months ago (2017-05-29 03:40:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
767d5ecbfd883fcfe506e67511d97f1601f42031 (presubmit successful).