Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: remoting/protocol/data_channel_handler.h

Issue 2907073003: [Chromoting] Add DataChannelManager to manage optional incoming data channels (Closed)
Patch Set: Resolve review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/data_channel_handler.h
diff --git a/remoting/protocol/data_channel_handler.h b/remoting/protocol/data_channel_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..4fcbd5b9380d2d38fa877a5a03605c98ae9b651a
--- /dev/null
+++ b/remoting/protocol/data_channel_handler.h
@@ -0,0 +1,84 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_PROTOCOL_DATA_CHANNEL_HANDLER_H_
+#define REMOTING_PROTOCOL_DATA_CHANNEL_HANDLER_H_
+
+#include <memory>
+#include <string>
+
+#include "base/callback.h"
+#include "base/sequenced_task_runner_helpers.h"
+#include "base/threading/thread_checker.h"
+#include "remoting/protocol/message_pipe.h"
+
+namespace google {
+namespace protobuf {
+class MessageLite;
+} // namespace protobuf
+} // namespace google
+
+namespace remoting {
+
+class CompoundBuffer;
+
+namespace protocol {
+
+// A base class to handle data from a named data channel. This class manages the
+// lifetime itself: it deletes itself once the data channel is closed or the
+// derived instance actively calls Close() function.
+class DataChannelHandler : public MessagePipe::EventHandler {
+ protected:
+ // Creates a DataChannelHandler to handle data from |pipe|.
+ // This class is not virtual, but it is an no-op instance. So hide the
+ // constructor.
+ DataChannelHandler(const std::string& name,
+ std::unique_ptr<MessagePipe> pipe);
+
+ ~DataChannelHandler() override;
+
+ // Closes the channel and eventually destructs this instance. No operations
+ // should be performed after executing this function.
+ void Close();
+
+ const std::string& pipe_name() const { return name_; }
+
+ // Returns true if |this| object has been scheduled to be deleted. This
+ // function always indicates the lifetime of |this| even the |pipe_| has never
+ // been opened.
+ bool finalized() const { return pipe_ == nullptr; }
+
+ // Whether |pipe_| has been connected.
+ bool connected() const { return is_connected_; }
+
+ // Returns false if the message is not sent, usually it happens before the
+ // |pipe_| is opened.
+ bool Send(google::protobuf::MessageLite* message, const base::Closure& done);
+
+ // Derived classes can override these functions to receive data from the
+ // connection or observe the connection state. These functions will not be
+ // called unless |pipe_| has been opened.
+
+ virtual void OnIncomingMessage(std::unique_ptr<CompoundBuffer> message);
+ virtual void OnConnected();
+ virtual void OnDisconnecting();
+
+ private:
+ friend class base::DeleteHelper<DataChannelHandler>;
+
+ // MessagePipe::EventHandler implementation.
+ void OnMessagePipeOpen() override;
+ void OnMessageReceived(std::unique_ptr<CompoundBuffer> message) override;
+ void OnMessagePipeClosed() override;
+
+ const std::string name_;
+ std::unique_ptr<MessagePipe> pipe_;
+ base::ThreadChecker thread_checker_;
+ bool is_connected_ = false;
+};
+
+} // namespace protocol
+} // namespace remoting
+
+#endif // REMOTING_PROTOCOL_DATA_CHANNEL_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698