third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp - Issue 2907063002: Make CounterDirectiveMap a class and implement a Clone() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp

Issue 2907063002: Make CounterDirectiveMap a class and implement a Clone() method. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp

diff --git a/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp b/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp

index 7a26d696dea54e571ebb85c185a2309e4a5f4f64..550fc04e03aa0f361eead303e7b270c96dd62e88 100644

--- a/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp

+++ b/third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp

@@ -154,7 +154,7 @@ StyleRareNonInheritedData::StyleRareNonInheritedData(

grid_item_(o.grid_item_),

scroll_snap_(o.scroll_snap_),

content_(o.content_ ? o.content_->Clone() : nullptr),

- counter_directives_(o.counter_directives_ ? Clone(*o.counter_directives_)

+ counter_directives_(o.counter_directives_ ? o.counter_directives_->Clone()

: nullptr),

animations_(o.animations_ ? o.animations_->Clone() : nullptr),

transitions_(o.transitions_ ? o.transitions_->Clone() : nullptr),