Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp

Issue 2907053004: GSB uses delta_hints to calculate scrolling chain. (Closed)
Patch Set: review comments addressed. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp b/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
index e54a7ddb1dfd726b724a8f67db0ff8f02d35d243..2c9304dc49571fd97bfacb7ed351bab23b5af202 100644
--- a/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
+++ b/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
@@ -108,13 +108,16 @@ class BrowserControlsTest : public ::testing::Test {
if (type == WebInputEvent::kGestureScrollUpdate) {
event.data.scroll_update.delta_x = delta_x;
event.data.scroll_update.delta_y = delta_y;
+ } else if (type == WebInputEvent::kGestureScrollBegin) {
+ event.data.scroll_begin.delta_x_hint = delta_x;
+ event.data.scroll_begin.delta_y_hint = delta_y;
}
return WebCoalescedInputEvent(event);
}
void VerticalScroll(float delta_y) {
GetWebView()->HandleInputEvent(
- GenerateEvent(WebInputEvent::kGestureScrollBegin));
+ GenerateEvent(WebInputEvent::kGestureScrollBegin, 0, delta_y));
GetWebView()->HandleInputEvent(
GenerateEvent(WebInputEvent::kGestureScrollUpdate, 0, delta_y));
GetWebView()->HandleInputEvent(

Powered by Google App Engine
This is Rietveld 408576698