third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp - Issue 2907053004: GSB uses delta_hints to calculate scrolling chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp

Issue 2907053004: GSB uses delta_hints to calculate scrolling chain. (Closed)

Patch Set: review comments addressed. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp

index fe5daa5c507dfb1514c22a6fe3ce551f2426da68..16e90b2ff7915f61bf605b0127dcc121835102a9 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp

@@ -32,6 +32,9 @@ ScrollState* ScrollState::Create(ScrollStateInit init) {

WTF::MakeUnique<ScrollStateData>();

scroll_state_data->delta_x = init.deltaX();

scroll_state_data->delta_y = init.deltaY();

+ scroll_state_data->delta_x_hint = init.deltaXHint();

+ scroll_state_data->delta_y_hint = init.deltaYHint();

+ scroll_state_data->ignore_delta_hints = init.ignoreDeltaHints();

scroll_state_data->position_x = init.positionX();

scroll_state_data->position_y = init.positionY();

scroll_state_data->velocity_x = init.velocityX();