Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: ui/events/blink/input_handler_proxy.cc

Issue 2907053004: GSB uses delta_hints to calculate scrolling chain. (Closed)
Patch Set: debug version Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/blink/input_handler_proxy.cc
diff --git a/ui/events/blink/input_handler_proxy.cc b/ui/events/blink/input_handler_proxy.cc
index 1ed598061c2dca8f038386555d8b46bf85c0df09..6c86bc7a96b8a5d424df43df8ab12332a73db2c8 100644
--- a/ui/events/blink/input_handler_proxy.cc
+++ b/ui/events/blink/input_handler_proxy.cc
@@ -141,6 +141,10 @@ cc::ScrollState CreateScrollStateForGesture(const WebGestureEvent& event) {
case WebInputEvent::kGestureScrollBegin:
scroll_state_data.position_x = event.x;
scroll_state_data.position_y = event.y;
+ scroll_state_data.delta_x_hint = -event.data.scroll_begin.delta_x_hint;
bokan 2017/05/30 15:57:44 The delta on a scroll_begin is called a hint, but
sahel 2017/05/30 16:02:06 I had this implementation initially, but ended up
bokan 2017/05/30 16:05:29 Tim is the expert here so I'll defer to him but pe
+ scroll_state_data.delta_y_hint = -event.data.scroll_begin.delta_y_hint;
+ scroll_state_data.ignore_delta_hints =
+ event.data.scroll_begin.ignore_delta_hints;
scroll_state_data.is_beginning = true;
// On Mac, a GestureScrollBegin in the inertial phase indicates a fling
// start.
@@ -825,8 +829,7 @@ InputHandlerProxy::EventDisposition InputHandlerProxy::HandleGestureScrollBegin(
} else if (ShouldAnimate(gesture_event.data.scroll_begin.delta_hint_units !=
blink::WebGestureEvent::ScrollUnits::kPixels)) {
DCHECK(!scroll_state.is_in_inertial_phase());
- gfx::Point scroll_point(gesture_event.x, gesture_event.y);
- scroll_status = input_handler_->ScrollAnimatedBegin(scroll_point);
+ scroll_status = input_handler_->ScrollAnimatedBegin(&scroll_state);
} else {
scroll_status = input_handler_->ScrollBegin(
&scroll_state, GestureScrollInputType(gesture_event.source_device));

Powered by Google App Engine
This is Rietveld 408576698