Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/public/platform/WebGestureEvent.h

Issue 2907053004: GSB uses delta_hints to calculate scrolling chain. (Closed)
Patch Set: Merge branch 'master' into GSB_checks_delta_hints Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGestureEvent_h 5 #ifndef WebGestureEvent_h
6 #define WebGestureEvent_h 6 #define WebGestureEvent_h
7 7
8 #include "WebFloatSize.h" 8 #include "WebFloatSize.h"
9 #include "WebGestureDevice.h" 9 #include "WebGestureDevice.h"
10 #include "WebInputEvent.h" 10 #include "WebInputEvent.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 float height; 78 float height;
79 } long_press; 79 } long_press;
80 80
81 struct { 81 struct {
82 float first_finger_width; 82 float first_finger_width;
83 float first_finger_height; 83 float first_finger_height;
84 } two_finger_tap; 84 } two_finger_tap;
85 85
86 struct { 86 struct {
87 // Initial motion that triggered the scroll. 87 // Initial motion that triggered the scroll.
88 // May be redundant with deltaX/deltaY in the first scrollUpdate.
89 float delta_x_hint; 88 float delta_x_hint;
90 float delta_y_hint; 89 float delta_y_hint;
90 bool ignore_delta_hints;
tdresser 2017/06/23 19:14:12 Why do we need this? Should it have a comment?
sahel 2017/06/23 20:01:00 As you mentioned in previous comments, relying on
91 // Default initialized to ScrollUnits::PrecisePixels. 91 // Default initialized to ScrollUnits::PrecisePixels.
92 ScrollUnits delta_hint_units; 92 ScrollUnits delta_hint_units;
93 // If true, this event will skip hit testing to find a scroll 93 // If true, this event will skip hit testing to find a scroll
94 // target and instead just scroll the viewport. 94 // target and instead just scroll the viewport.
95 bool target_viewport; 95 bool target_viewport;
96 // The state of inertial phase scrolling. OSX has unique phases for normal 96 // The state of inertial phase scrolling. OSX has unique phases for normal
97 // and momentum scroll events. Should always be UnknownMomentumPhase for 97 // and momentum scroll events. Should always be UnknownMomentumPhase for
98 // touch based input as it generates GestureFlingStart instead. 98 // touch based input as it generates GestureFlingStart instead.
99 InertialPhaseState inertial_phase; 99 InertialPhaseState inertial_phase;
100 // True if this event was synthesized in order to force a hit test; 100 // True if this event was synthesized in order to force a hit test;
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 return false; 241 return false;
242 } 242 }
243 } 243 }
244 }; 244 };
245 245
246 #pragma pack(pop) 246 #pragma pack(pop)
247 247
248 } // namespace blink 248 } // namespace blink
249 249
250 #endif // WebGestureEvent_h 250 #endif // WebGestureEvent_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698