third_party/WebKit/Source/core/page/scrolling/ScrollStateInit.idl - Issue 2907053004: GSB uses delta_hints to calculate scrolling chain.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/page/scrolling/ScrollStateInit.idl

Issue 2907053004: GSB uses delta_hints to calculate scrolling chain. (Closed)

Patch Set: debug version Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/trees/layer_tree_host_impl.cc ('K') | « third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp ('k') | third_party/WebKit/Source/web/WebInputEvent.cpp » ('j') | ui/events/blink/input_handler_proxy.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://docs.google.com/document/d/1VnvAqeWFG9JFZfgG5evBqrLGDZYRE5w6G5jEDORek PY	5 // https://docs.google.com/document/d/1VnvAqeWFG9JFZfgG5evBqrLGDZYRE5w6G5jEDORek PY

6	6

7 dictionary ScrollStateInit {	7 dictionary ScrollStateInit {

8 double deltaX = 0;	8 double deltaX = 0;

9 double deltaY = 0;	9 double deltaY = 0;

	10 double deltaXHint = 0;
	dtapuska 2017/05/30 15:20:38 This seems odd to add. best to talk to tdresser@ i This seems odd to add. best to talk to tdresser@ if you haven't. sahel 2017/05/30 15:36:14 Don't we have all fields here? I will talk to tdre Show quoted text On 2017/05/30 15:20:38, dtapuska wrote: > This seems odd to add. best to talk to tdresser@ if you haven't. Don't we have all fields here? I will talk to tdresser@.
	11 double deltaYHint = 0;

	12 boolean ignoreDeltaHints = false;

10 long positionX = 0;	13 long positionX = 0;

11 long positionY = 0;	14 long positionY = 0;

12 double velocityX = 0;	15 double velocityX = 0;

13 double velocityY = 0;	16 double velocityY = 0;

14 boolean isBeginning = false;	17 boolean isBeginning = false;

15 boolean isInInertialPhase = false;	18 boolean isInInertialPhase = false;

16 boolean isEnding = false;	19 boolean isEnding = false;

17 boolean shouldPropagate = true;	20 boolean shouldPropagate = true;

18 boolean fromUserInput = false;	21 boolean fromUserInput = false;

19 boolean isDirectManipulation = false;	22 boolean isDirectManipulation = false;

20 double deltaGranularity = 0;	23 double deltaGranularity = 0;

21 };	24 };

OLD	NEW