Issue 2907023003: Change dependency walker's Node.dependencies to a static getter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2907023003: Change dependency walker's Node.dependencies to a static getter. (Closed)

Created:
3 years, 6 months ago by Paul Berry

Modified:
3 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Change dependency walker's Node.dependencies to a static getter. This prevents it from being accidentally overridden in a derived class. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9a64339646014527f0fdd8e0f5b6a7466fd375b6

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	pkg/analyzer/lib/src/summary/link.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/front_end/lib/src/dependency_walker.dart	View		3 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 6 months ago (2017-05-28 04:27:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9a64339646014527f0fdd8e0f5b6a7466fd375b6 (presubmit successful).