Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2907003002: Update test failures after 3b9cf73. (Closed)

Created:
3 years, 6 months ago by sivachandra
Modified:
3 years, 6 months ago
Reviewers:
aam
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update test failures after 3b9cf73. BUG= TBR=aam Committed: https://github.com/dart-lang/sdk/commit/a5aaa7f5ebf3e8eee282b42d3ebf34c82e206cb7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adjust failure mode and put the failing tests in the correct blacklist #

Patch Set 3 : Update test failures after 3b9cf73. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/observatory/tests/service/service.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sivachandra
3 years, 6 months ago (2017-05-27 04:32:02 UTC) #2
aam
https://codereview.chromium.org/2907003002/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/2907003002/diff/1/runtime/tests/vm/vm.status#newcode334 runtime/tests/vm/vm.status:334: cc/Debugger_SetBreakpointInFunctionLiteralFieldInitializers : Fail I think this should be marked ...
3 years, 6 months ago (2017-05-27 04:40:09 UTC) #3
sivachandra
Committed patchset #3 (id:40001) manually as a5aaa7f5ebf3e8eee282b42d3ebf34c82e206cb7 (presubmit successful).
3 years, 6 months ago (2017-05-27 05:57:30 UTC) #6
aam
3 years, 6 months ago (2017-05-27 13:58:30 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698