Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: ios/chrome/browser/ui/history/history_service_facade.mm

Issue 2906953003: Remove ScopedVector usage from components/history (Closed)
Patch Set: Remove ScopedVector usage from components/history Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/history/history_service_facade.mm
diff --git a/ios/chrome/browser/ui/history/history_service_facade.mm b/ios/chrome/browser/ui/history/history_service_facade.mm
index d228b76021d651c6832a33057d6d4ae348572a0b..fb181b913c8f11287f10be9903380af5bc3b979e 100644
--- a/ios/chrome/browser/ui/history/history_service_facade.mm
+++ b/ios/chrome/browser/ui/history/history_service_facade.mm
@@ -275,11 +275,11 @@ void HistoryServiceFacade::QueryComplete(const base::string16& search_text,
DCHECK_EQ(0U, query_results_.size());
query_results_.reserve(results->size());
- for (history::URLResult* result : *results) {
+ for (const auto& result : *results) {
query_results_.push_back(history::HistoryEntry(
- history::HistoryEntry::LOCAL_ENTRY, result->url(), result->title(),
- result->visit_time(), std::string(), !search_text.empty(),
- result->snippet().text(), result->blocked_visit()));
+ history::HistoryEntry::LOCAL_ENTRY, result.url(), result.title(),
+ result.visit_time(), std::string(), !search_text.empty(),
+ result.snippet().text(), result.blocked_visit()));
}
results_info_value_.query = search_text;
« no previous file with comments | « ios/chrome/browser/tabs/tab_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698