Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/api/history/history_api.cc

Issue 2906953003: Remove ScopedVector usage from components/history (Closed)
Patch Set: Remove ScopedVector usage from components/history Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | chrome/browser/ui/webui/browsing_history_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/history/history_api.cc
diff --git a/chrome/browser/extensions/api/history/history_api.cc b/chrome/browser/extensions/api/history/history_api.cc
index b5e49a22470cb2a1d82277d3751269a0d0f433e9..c80346ed4d81e544ccc22161cabeb93c9b094ba8 100644
--- a/chrome/browser/extensions/api/history/history_api.cc
+++ b/chrome/browser/extensions/api/history/history_api.cc
@@ -324,8 +324,8 @@ ExtensionFunction::ResponseAction HistorySearchFunction::Run() {
void HistorySearchFunction::SearchComplete(history::QueryResults* results) {
HistoryItemList history_item_vec;
if (results && !results->empty()) {
- for (const history::URLResult* item : *results)
- history_item_vec.push_back(GetHistoryItem(*item));
+ for (const auto& item : *results)
+ history_item_vec.push_back(GetHistoryItem(item));
}
Respond(ArgumentList(Search::Results::Create(history_item_vec)));
Release(); // Balanced in Run().
« no previous file with comments | « AUTHORS ('k') | chrome/browser/ui/webui/browsing_history_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698