Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2906953002: [DMC #26] Add CompositionMarker::Thickness enum (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index 6cc9533dcf124e0874da6bff9815d399c0a75fca..5453a3bb3cb387c2ad1bea4b357ee7619306198f 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -465,7 +465,9 @@ void InputMethodController::AddCompositionUnderlines(
continue;
GetDocument().Markers().AddCompositionMarker(
- ephemeral_line_range, underline.GetColor(), underline.Thick(),
+ ephemeral_line_range, underline.GetColor(),
+ underline.Thick() ? CompositionMarker::Thickness::kThick
+ : CompositionMarker::Thickness::kThin,
underline.BackgroundColor());
}
}
@@ -689,7 +691,8 @@ void InputMethodController::SetComposition(
if (underlines.IsEmpty()) {
GetDocument().Markers().AddCompositionMarker(
- EphemeralRange(composition_range_), Color::kBlack, false,
+ EphemeralRange(composition_range_), Color::kBlack,
+ CompositionMarker::Thickness::kThin,
LayoutTheme::GetTheme().PlatformDefaultCompositionBackgroundColor());
return;
}

Powered by Google App Engine
This is Rietveld 408576698